Refine Clear-Site-Data deletion criteria #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
changed the title
csharrison
reviewed
Sep 30, 2025
csharrison
approved these changes
Sep 30, 2025
|
@martinthomson Any concerns with merging this? |
martinthomson
approved these changes
Oct 29, 2025
| 1. [=set/iterate|For each=] [=impression=] |impression| of | ||
| the [=impression store=]: | ||
|
|
||
| 1. If |impression|'s [=impression/Intermediary Site=] is `undefined` and |
There was a problem hiding this comment.
Why only do this if the intermediary site is undefined? Shouldn't this happen no matter what the intermediary site is set to?
There was a problem hiding this comment.
It depends on whether we want the impression site to be able to delete impressions that were registered by an intermediary, or whether the impression site should only be able to delete impressions registered by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289
Preview | Diff